Avoid double-update to doc_auth_logs table#7550
Merged
mitchellhenke merged 1 commit intomainfrom Dec 29, 2022
Merged
Conversation
changelog: Internal, Database Optimization, Avoid double-update to doc_auth_logs table
mitchellhenke
force-pushed
the
mitchellhenke/avoid-double-doc-auth-write
branch
from
8a7c636 to
33ebfb1
Compare
mdiarra3
approved these changes
Dec 29, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Currently
RegisterSubmitSteppotentially updates a column or two and then updates a second set of columns. This behavior doesn't seem to be required and appears to be a small, but unnecessary increase in write load on the database.I suspect there are steps in the doc auth flow where
RegisterSubmitStepis called multiple times quickly, so there's potential to improve this further as well.