Merged
Conversation
changelog: Internal, Health Checks, Remove account reset health check
mitchellhenke
force-pushed
the
mitchellhenke/remove-account-reset-request-health-check
branch
from
7b32c97 to
74ad746
Compare
mdiarra3
approved these changes
Dec 29, 2022
mitchellhenke
deleted the
mitchellhenke/remove-account-reset-request-health-check
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
The AccountResetHealthCheck was added a few years back, and we've built up much better alerting and monitoring around background jobs since then. The query for the health check is also unindexed and can take tens of milliseconds to run. With both of those things, I think it's ok to retire this health check.
(This was in part prompted by #7547)