Skip to content

Updating ThreatMetrix failure (sad face) screen content #7529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eric-gade merged 3 commits into from
Dec 22, 2022
Merged

Updating ThreatMetrix failure (sad face) screen content #7529

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
74dc655
Updating ThreatMetrix failure (sad face) screen content
Dec 21, 2022
9deccd8
Lints
Dec 22, 2022
e2a68fb
Adding contact center number to config and setting dummy default
Dec 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/views/idv/setup_errors/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
title: t('titles.failure.information_not_verified'),
heading: t('idv.failure.setup.heading'),
) do %>
<p>
<%= t('idv.failure.setup.fail_html', contact_form_link: link_to(t('idv.failure.setup.link_text'), contact_redirect_url(flow: :idv, step: :secure_account)), support_code: IdentityConfig.store.lexisnexis_threatmetrix_support_code) %>
</p>
<p>
<%= t('idv.failure.setup.fail_html', support_code: IdentityConfig.store.lexisnexis_threatmetrix_support_code) %>
</p>
<% end %>
8 changes: 4 additions & 4 deletions config/locales/idv/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,10 @@ en:
warning: Please check the information you entered and try again. Common mistakes
are an incorrect Social Security number or ZIP Code.
setup:
fail_html: Please %{contact_form_link} and enter the code <b>%{support_code}</b>
in the detail field.
heading: There is an issue with your information
link_text: fill out our contact form
fail_html: 'Please call our contact center at <strong>(844) 875-6446</strong> to

@aduth aduth Dec 22, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it could be wise to make this configurable or at least constant-ized, with a placeholder value in the default configuration. For example, I expect we wouldn't want people using this number if they were testing in a lower sandbox environment.

@eric-gade eric-gade Dec 22, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I was mulling that over that yesterday (here). It's unclear to me how this live call part of things gets tested. That said, I think you're right.

@theabrad theabrad Dec 22, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this phone number should probably be stored in the IdentityConfig.store

continue verifying your identity. You will need to provide them with
the error code <strong>%{support_code}</strong>.'
heading: Please give us a call
timeout: We are experiencing higher than usual wait time processing your
request. Please try again.
forgot_password:
Expand Down
8 changes: 4 additions & 4 deletions config/locales/idv/es.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,10 @@ es:
Los errores más comunes suelen producirse al ingresar un Número de
Seguridad Social o un Código Postal incorrecto.
setup:
fail_html: Por favor, %{contact_form_link} e introduzca el código
<b>%{support_code}</b> en el campo de detalle.
heading: Hay un problema con tu información
link_text: rellene nuestro formulario decontacto
fail_html: Llame a nuestro centro de contacto al <strong>(844) 875-6446</strong>
para seguir verificando su identidad. Deberá proporcionarnos el código
de error <strong>%{support_code}</strong>.
heading: Llámenos
timeout: Estamos experimentando un tiempo de espera superior al habitual al
procesar su solicitud. Inténtalo de nuevo.
forgot_password:
Expand Down
9 changes: 5 additions & 4 deletions config/locales/idv/fr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,11 @@ fr:
Les erreurs les plus courantes sont un numéro de sécurité sociale ou
un code postal incorrect.
setup:
fail_html: Veuillez %{contact_form_link} et entrer le code
<b>%{support_code}</b> dans le champ de détail.
heading: Il y a un problème avec vos informations
link_text: remplir notre formulaire de contact
fail_html: Veuillez appeler notre centre de contact au <strong>(844)
875-6446</strong> pour poursuivre la vérification de votre identité.
Vous devrez leur fournir le code d’erreur
<strong>%{support_code}</strong>.
heading: S’il vous plaît, appelez-nous
timeout: Le temps d’attente pour le traitement de votre demande est plus long
que d’habitude Veuillez réessayer.
forgot_password:
Expand Down
1 change: 0 additions & 1 deletion spec/views/idv/setup_errors/show.html.erb_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
strip_tags(
t(
'idv.failure.setup.fail_html',
contact_form_link: t('idv.failure.setup.link_text'),
support_code: 'ABCD',
),
),
Expand Down