Skip to content

LG-8438: Update language on pages related to OTP #7515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jc-gsa merged 3 commits into from
Dec 21, 2022
+14 −9
Merged

LG-8438: Update language on pages related to OTP #7515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c2d950
Change text for voice call input code
jc-gsa Dec 19, 2022
8eb87e7
Add translations for SMS
jc-gsa Dec 20, 2022
0758eb9
Update tests
jc-gsa Dec 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions config/locales/instructions/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,12 @@ en:
try_again: try again
sms:
confirm_code_html: Need another code? %{resend_code_link}. Message rates may apply.
number_message_html: We sent a one-time code to %{number}. This code will expire
in %{expiration} minutes.
number_message_html: We sent a text (SMS) with a one-time code to %{number}.
This code will expire in %{expiration} minutes.
voice:
confirm_code_html: Want us to call you again? %{resend_code_link}
number_message_html: We just called you at %{number}.
number_message_html: We made a call with a one-time code to %{number}. This code
will expire in %{expiration} minutes.
webauthn:
confirm_webauthn_html: Present the security key that you associated with your account.
confirm_webauthn_only_html: This app requires a higher level of security. You
Expand Down
7 changes: 4 additions & 3 deletions config/locales/instructions/es.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,12 @@ es:
sms:
confirm_code_html: '¿Necesita otro código? %{resend_code_link}. Puede estar
sujeto a cargos de mensajería y datos.'
number_message_html: Hemos enviado un código único al %{number}. Este código
expirará en %{expiration} minutos.
number_message_html: Enviamos un mensaje de texto (SMS) con un código único al
%{number}. Este código caducará en %{expiration} minutos.
voice:
confirm_code_html: '¿Desea que le llamemos de nuevo? %{resend_code_link}'
number_message_html: Acabamos de llamarte en %{number}.
number_message_html: Realizamos una llamada con un código de un solo uso al
%{number}. Este código expirará en %{expiration} minutos.
webauthn:
confirm_webauthn_html: Presente la clave de seguridad que asoció con su cuenta.
confirm_webauthn_only_html: Esta aplicación requiere un mayor nivel de
Expand Down
7 changes: 4 additions & 3 deletions config/locales/instructions/fr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,11 +79,12 @@ fr:
sms:
confirm_code_html: Vous avez besoin d’un autre code? %{resend_code_link}. Les
frais liés aux messages texte peuvent s’appliquer.
number_message_html: Nous avons envoyé un code à usage unique au %{number}. Ce
code expirera dans %{expiration} minutes.
number_message_html: Nous avons envoyé un texte (SMS) avec un code à usage
unique au %{number}. Ce code expirera dans %{expiration} minutes.
voice:
confirm_code_html: Vous voulez que nous vous appelions de nouveau? %{resend_code_link}
number_message_html: Nous venons de vous appeler à %{number}.
number_message_html: Nous avons envoyé un code à usage unique par appel au
%{number}. Ce code expirera dans %{expiration} minutes.
webauthn:
confirm_webauthn_html: Présentez la clé de sécurité associée à votre compte.
confirm_webauthn_only_html: Cette application nécessite un niveau de sécurité
Expand Down
2 changes: 2 additions & 0 deletions spec/features/phone/default_phone_selection_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@
expect(page).to have_content t(
'instructions.mfa.voice.number_message_html',
number: '+1 202-555-3434',
expiration: TwoFactorAuthenticatable::DIRECT_OTP_VALID_FOR_MINUTES,
)

submit_prefilled_otp_code(user, 'voice')
Expand All @@ -121,6 +122,7 @@
expect(page).to have_content t(
'instructions.mfa.voice.number_message_html',
number: '(***) ***-3434',
expiration: TwoFactorAuthenticatable::DIRECT_OTP_VALID_FOR_MINUTES,
)
end
end
Expand Down