Redirect to TM sad screen after GPO verification#7508
Merged
Conversation
matthinz
force-pushed
the
matthinz/8351-gpo-threatmetrix
branch
2 times, most recently
from
0cfb16d to
e325207
Compare
matthinz
commented
Dec 21, 2022
matthinz
commented
Dec 21, 2022
Contributor
Author
There was a problem hiding this comment.
I pulled these out into a shared example:
prompts for one-time code at sign inrenders an error for an expired GPO OTPallows a user to resend a letter
The idea is that all the standard GPO OTP verification stuff should be unaffected by ThreatMetrix status: if you fail ThreatMetrix, you can still verify your account, but afterwards you'll have to take steps to fully activate.
matthinz
changed the title
matthinz
commented
Dec 22, 2022
matthinz
force-pushed
the
matthinz/8351-gpo-threatmetrix
branch
from
931be29 to
0c5689b
Compare
matthinz
commented
Dec 22, 2022
Comment on lines
209
to
245
Contributor
Author
There was a problem hiding this comment.
Relevant Slack thread discussing this: https://gsa-tts.slack.com/archives/CNCGEHG1G/p1671730304506409
theabrad
requested changes
Dec 23, 2022
matthinz
force-pushed
the
matthinz/8351-gpo-threatmetrix
branch
from
2a9c296 to
476aec9
Compare
If ThreatMetrix check had previously failed, redirect user to the "sad screen" after they enter their OTP
…r GPO OTP verification
Check that accoutn is verified if it should be, that the deactivation_reason is set, etc.
Idea being that, even though account is technically "verified", the messaging to the user will need to come through the TM appeal process.
Match other logic in place in PersonalKeyController
matthinz
force-pushed
the
matthinz/8351-gpo-threatmetrix
branch
from
476aec9 to
49b0563
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-8351
🛠 Summary of changes
Updates GPO OTP verification such that if the user failed a ThreatMetrix check before verifying their OTP, their account is verified, but created in the
threatmetrix_review_pendingstate.📜 Testing Plan