Merged
Conversation
changelog: Bug Fixes, Forms, Improve consistency of example hint texts
theabrad
approved these changes
Dec 5, 2022
|
@aduth - Forgive me, I don't know if the IDP has different files for (1) the hybrid flow handoff telephone input and (2) the SSN input. Would your changes cover all of those screens, or just the ones here for (3) phone verification? |
Contributor
Author
This would cover most of the screens (all of the ones affected in the prior pull request). There's other strings which also use similar hint text, but those are already capitalized as expected (e.g. the "Memorable Date" component). |
benjaminchait
approved these changes
Dec 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-8297
🛠 Summary of changes
Reverts the change in #7330 which revised the hint label from capitalized "Example" to lower-case "example".
Related discussion:
📜 Testing Plan
👀 Screenshots