Skip to content

LG-8297: Capitalize "Example" hint labels#7432

Merged
aduth merged 2 commits intomainfrom
aduth-lg-8297-capitalize-example
Dec 6, 2022
Merged

LG-8297: Capitalize "Example" hint labels#7432
aduth merged 2 commits intomainfrom
aduth-lg-8297-capitalize-example

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Dec 5, 2022

🎫 Ticket

LG-8297

🛠 Summary of changes

Reverts the change in #7330 which revised the hint label from capitalized "Example" to lower-case "example".

Related discussion:

📜 Testing Plan

  • Check that every hint label in the application uses "Example" upper-case (e.g. IdV phone step)

👀 Screenshots

Before After
image image

changelog: Bug Fixes, Forms, Improve consistency of example hint texts
@benjaminchait
Copy link

@aduth - Forgive me, I don't know if the IDP has different files for (1) the hybrid flow handoff telephone input and (2) the SSN input. Would your changes cover all of those screens, or just the ones here for (3) phone verification?

@aduth
Copy link
Contributor Author

aduth commented Dec 5, 2022

@aduth - Forgive me, I don't know if the IDP has different files for (1) the hybrid flow handoff telephone input and (2) the SSN input. Would your changes cover all of those screens, or just the ones here for (3) phone verification?

This would cover most of the screens (all of the ones affected in the prior pull request). There's other strings which also use similar hint text, but those are already capitalized as expected (e.g. the "Memorable Date" component).

Copy link
Contributor

@eric-gade eric-gade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aduth aduth merged commit a10050d into main Dec 6, 2022
@aduth aduth deleted the aduth-lg-8297-capitalize-example branch December 6, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants