Move InPersonURL configuration into new InPerson context#7424
Merged
allthesignals merged 2 commits intomainfrom Dec 5, 2022
Merged
Move InPersonURL configuration into new InPerson context#7424allthesignals merged 2 commits intomainfrom
allthesignals merged 2 commits intomainfrom
Conversation
…ration into new InPerson context Also makes InPerson context a typescript class
allthesignals
force-pushed
the
wmg/7927-in-person-context-refactor
branch
from
b473415 to
b14d2fb
Compare
allthesignals
force-pushed
the
wmg/7927-in-person-context-refactor
branch
from
7e14e0f to
6a7ee14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by this and this.
This moves InPersonURL from the FlowContext into the new InPersonContext, in order to keep in-person configuration together.
🎫 Ticket
Refactoring effort peeled off from a suggestion made in #7385.