Remove PhoneConfirmation namespace#7409
Merged
zachmargolis merged 6 commits intomainfrom Nov 30, 2022
Merged
Conversation
- Inline logic in ConfirmationSession
…onSession **Why**: PhoneConfirmation namespace only used in IDV, didn't need to be its own thing
[skip changelog]
aduth
approved these changes
Nov 30, 2022
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
I encountered this recently as well, and based on the commit message of 3a55e8d, I got the impression there'd been some desire to consolidate the handling of OTP confirmation between IdV and MFA. I still think that'd be a nice direction to move, but as things stand, I agree these classes cause me some confusion in how they're used specifically for IdV.
mdiarra3
approved these changes
Nov 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "PhoneConfirmation" namespace had two classes:
This is all syntax sugar, small cleanups, if anybody has reasons they want to keep things as-is, I'm happy to close this PR