Remove Db::DeletedUser::Create, move logic to DeletedUser#7407
Merged
zachmargolis merged 2 commits intomainfrom Nov 30, 2022
Merged
Remove Db::DeletedUser::Create, move logic to DeletedUser#7407zachmargolis merged 2 commits intomainfrom
zachmargolis merged 2 commits intomainfrom
Conversation
[skip changelog]
zachmargolis
commented
Nov 29, 2022
Comment on lines
23
to
26
| ActiveRecord::Base.transaction do | ||
| Db::DeletedUser::Create.call(current_user.id) | ||
| DeletedUser.create_from_user(current_user) | ||
| current_user.destroy! | ||
| end |
Contributor
Author
There was a problem hiding this comment.
the one argument I could see for keeping around a separate service object to manage creating deleted users, is having a single object that's OK to modify two separate tables
This pattern/transaction is repeated in two places, and ideally one object/method could handle both. However, it's only repeated once so I think it's OK to leave like this
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One fewer namespace (
Db::DeletedUser) and one fewer single-method class