Skip to content

Fix flaky GPO exporter test #7400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthinz merged 2 commits into from
Nov 29, 2022
Merged

Fix flaky GPO exporter test #7400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c59b8fc
Fix flaky GPO exporter test
matthinz Nov 28, 2022
24f623b
Update app/services/gpo_confirmation_exporter.rb
matthinz Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/services/gpo_confirmation_exporter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def make_entry_row(confirmation)
end

def format_date(date)
"#{date.strftime('%-B %-e')}, #{date.year}"
date.in_time_zone('UTC').strftime('%-B %-e, %Y')
end

def current_date
Expand Down
2 changes: 1 addition & 1 deletion spec/services/gpo_confirmation_exporter_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
describe '#run' do
before do
allow(IdentityConfig.store).to receive(:usps_confirmation_max_days).and_return(10)
allow(subject).to receive(:current_date).and_return(Time.zone.local(2018, 7, 6))
allow(subject).to receive(:current_date).and_return(Time.utc(2018, 7, 6))
end

it 'creates psv string' do
Expand Down