LG-7925 Backend pings USPS API for IPP locations

[eileen-nava]

🎫 Ticket

LG-7925: Results - controller search USPS endpoint

🛠 Summary of changes

• Add a call to the USPS's GetIppFacilityList route, via the UspsInPersonProofing's request_facilities method
• Put work behind the arcgis_search_enabled feature flag

📜 Testing Plan

• Run automated tests

[allthesignals]

Now that this switch from post to get has been deployed, it should be safe to remove this

[allthesignals]

Great.

Since I'm also hiding the frontend behavior behind feature flag, it should be aligned.

[allthesignals]

As far as I understand, there's no additional work needed to make request_facilities ready to go...

[allthesignals]

Looping in @tomas-nava for context

[eileen-nava]

That’s my understanding, too. FYSA, when I logged into dev, I was able to successfully use the request_facilities(location) method.

[allthesignals]

So, is coverage of request_pilot_facilities something we really want to remove during this transitional period? It'll still be needed for production until we flip the switch on.

[eileen-nava]

Good point! I can add the test coverage for request_pilot_facilities back into this PR. 🙏🏻

[allthesignals]

non-blocking observation:

one pattern I've learned about from zach is to wrap an "external" class like this in a method and stub that method instead: https://github.com/18F/identity-idp/blob/main/app/controllers/idv/in_person/address_search_controller.rb#L22-L24.

So, you could have a proofer method, and you'd simply mock that instead of needed to mock UspsInPersonProofing::Proofer directly.

[zachmargolis]

zach agrees!

[eileen-nava]

I implemented this change in the controller. I haven't changed the test setup, but can do so tomorrow. I'm logging off for the day, but I am also considering mocking the proofer. Sheldon suggested this refactor, and noted this method in the enrollment_helper.rb as potential inspiration.

      def usps_proofer
        if IdentityConfig.store.usps_mock_fallback
          UspsInPersonProofing::Mock::Proofer.new
        else
          UspsInPersonProofing::Proofer.new
        end
      end

[zachmargolis]

zach also likes mocking the proofer, esp useful for lower envs

that said, I'm wondering if it would be ok to use "real" arcgis in a lower env, like we use real SMS and real voice so people can acually use the app

[eileen-nava]

Good question. I'll bring this up during the next PO search check-in meeting.

[allthesignals]

i think it's probably fine. i suspect voice and SMS billing is done on a credit system? we're using GSA's hosted service, and it isn't constrained in that way. open to other angles, though!

[zachmargolis]

Another thought: if the idea is to have addresses that are close to PO locations... and in mock world the PO locations are fake, maybe it does make sense to have a fake here? So that it can return things that the mock USPS service recognizes? I could go either way on this

[allthesignals]

I misunderstood! I think that makes sense, for the local environment.

[allthesignals]

Approving now with understanding that we should stub the new proofer method in tests rather than stubbing Proofer class directly