Merged
Conversation
solipet
approved these changes
Nov 22, 2022
Contributor
solipet
left a comment
solipet
left a comment
There was a problem hiding this comment.
This looks good to me. I wonder if we need the check in the document_capture_step if we are raising an error in the initializer, but it doesn't bother me to have both.
solipet
force-pushed
the
jskinne3-LG-8150-disable-async-proofing
branch
from
eec8d1c to
17b7197
Compare
config/application.yml.default
Outdated
Contributor
There was a problem hiding this comment.
I think this breaks a test assumption that the specs have, the analytics spec is looking for async doc upload:
Expected that FakeAnalytics would have received event "Frontend: IdV: document capture async upload encryption"
Contributor
Author
There was a problem hiding this comment.
What is the motivation for this change? I assume that subsequent changes to spec/features/idv/analytics_spec.rb are attempts to compensate for the breaking assumption that Zach mentions.
solipet
force-pushed
the
jskinne3-LG-8150-disable-async-proofing
branch
3 times, most recently
from
c073bb4 to
9221367
Compare
…nc proofing enabled
solipet
force-pushed
the
jskinne3-LG-8150-disable-async-proofing
branch
from
caf35b1 to
b3b3031
Compare
jmhooper
approved these changes
Dec 9, 2022
Contributor
|
Opened LG-8350 to look at differences in attribute logging between prod and specs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://cm-jira.usa.gov/browse/LG-8150
🛠 Summary of changes
Because
DocumentCaptureStep.callis insecure when async proofing is on:doc_auth_enable_presigned_s3_urlsconfig📜 Testing Plan