Conversation
changelog: Internal, Automated Testing, Improve reliability of successful automated tests
jscodefix
approved these changes
Nov 22, 2022
Contributor
jscodefix
left a comment
jscodefix
left a comment
There was a problem hiding this comment.
Based on your prior (identical) fixes, LGTM.
Contributor
|
This flakey spec failure was also holding up my PR CI tests passage. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Attempts to resolve an email mailer spec which is commonly failing intermittently.
Slack discussion: https://gsa-tts.slack.com/archives/C0NGESUN5/p1669069995915509
Same premise as #7359.
There are a couple other occurrences of
User#email_addressesin this file, but based on how they're used, they shouldn't be prone to the same problem.