Conversation
Contributor
|
Thanks Brendan. We will also be de-DSLogon-ifying soon. 👍 |
Contributor
|
@brendansudol go ahead and add |
Contributor
Author
|
cool, thanks @amoose -- tag added! |
Contributor
There was a problem hiding this comment.
Minor nitpick: this file is missing a newline at the end.
Contributor
There was a problem hiding this comment.
I know this was not introduced in this PR, but something to enhance in the future is to move the logo link to a partial to reduce duplication.
Contributor
There was a problem hiding this comment.
Or maybe even better, use the Rails link_to_if or link_to_unless helpers.
Contributor
|
LGTM 🚢 |
zachmargolis
pushed a commit
that referenced
this pull request
Sep 20, 2024
Bumps [globalid](https://github.com/rails/globalid) from 0.4.2 to 1.0.1. - [Release notes](https://github.com/rails/globalid/releases) - [Commits](rails/globalid@v0.4.2...v1.0.1) --- updated-dependencies: - dependency-name: globalid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
why
fixing a few UI oddities / bugs; make nav logo clickable
before:
after:
