Skip to content

Remove unreachable liveness content on device choice (upload) step #7268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 1 commit into from
Nov 1, 2022
Merged

Remove unreachable liveness content on device choice (upload) step #7268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions app/javascript/packs/upload-step.js
View file
Open in desktop

This file was deleted.

27 changes: 10 additions & 17 deletions app/views/idv/doc_auth/upload.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
) %>
</div>
<div class="grid-col-12 tablet:grid-col-9">
<div id="recommended-tag" class="usa-tag text-ink bg-primary-lighter margin-top-1">
<div class="usa-tag text-ink bg-primary-lighter margin-top-1">
<%= t('doc_auth.info.tag') %>
</div>
<h2 class="margin-y-105">
Expand All @@ -46,21 +46,14 @@

<hr class="margin-y-4" />

<div id="upload-comp-liveness-off">
<%= t('doc_auth.info.upload_from_computer') %>&nbsp;
<%= simple_form_for(
:doc_auth,
url: url_for(type: :desktop),
method: 'PUT',
html: { autocomplete: 'off', class: 'display-inline' },
) do |f| %>
<%= f.submit t('doc_auth.info.upload_computer_link'), unstyled: true, big: false, wide: false %>
<% end %>
</div>
<div id="upload-comp-liveness" class="display-none">
<strong><%= t('doc_auth.info.upload_from_computer') %></strong>
<%= t('doc_auth.info.upload_from_computer_not_allowed', app_name: APP_NAME) %>
</div>
<%= t('doc_auth.info.upload_from_computer') %>&nbsp;
<%= simple_form_for(
:doc_auth,
url: url_for(type: :desktop),
method: 'PUT',
html: { class: 'display-inline' },
) do |f| %>
<%= f.submit t('doc_auth.info.upload_computer_link'), unstyled: true, big: false %>
<% end %>

<%= render 'idv/doc_auth/cancel', step: 'upload' %>
<%= javascript_packs_tag_once 'upload-step' %>
2 changes: 0 additions & 2 deletions config/locales/doc_auth/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,8 +170,6 @@ en:
upload: We’ll collect information about you by reading your state-issued ID.
upload_computer_link: Upload from your computer
upload_from_computer: Don’t have a phone?
upload_from_computer_not_allowed: Sign in to your %{app_name} account on any
device that has a camera, like a tablet or computer with a webcam.
upload_from_phone: Upload pictures directly from your phone camera
upload_no_image_storage: We do not store images you upload. We only verify your identity.
verify_identity: We’ll ask for your personal information to verify your identity
Expand Down
3 changes: 0 additions & 3 deletions config/locales/doc_auth/es.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,9 +203,6 @@ es:
expedido por el estado.
upload_computer_link: Sube desde tu computadora
upload_from_computer: '¿No tiene un teléfono?'
upload_from_computer_not_allowed: Inicie sesión en su cuenta de %{app_name} en
cualquier dispositivo que tenga una cámara, como una tableta o una
computadora con una cámara web.
upload_from_phone: Sube imágenes directamente desde la cámara de tu teléfono
upload_no_image_storage: No almacenamos imágenes que cargue. Solo verificamos su identidad.
verify_identity: Le preguntaremos sus datos personales para verificar su
Expand Down
3 changes: 0 additions & 3 deletions config/locales/doc_auth/fr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,9 +213,6 @@ fr:
d’identité délivrée par l’État.
upload_computer_link: Téléchargez depuis votre ordinateur
upload_from_computer: Vous n’avez pas de téléphone?
upload_from_computer_not_allowed: Connectez-vous à votre compte %{app_name} sur
tout appareil doté d’une caméra, comme une tablette ou un ordinateur
avec une caméra Web.
upload_from_phone: Téléchargez des images directement depuis l’appareil photo de
votre téléphone
upload_no_image_storage: Nous ne stockons pas les images que vous téléchargez.
Expand Down
5 changes: 0 additions & 5 deletions spec/support/features/doc_auth_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,11 +98,6 @@ def complete_doc_auth_steps_before_upload_step(expect_accessible: false)
end

def complete_upload_step
if javascript_enabled?
# By default, user would be prevented from continuing on desktop if the proofing flow requires
# liveness and there is no detectable camera. This forces the desktop link to be visible.
page.find('#upload-comp-liveness-off', visible: :all).evaluate_script('this.className = ""')
end
click_on t('doc_auth.info.upload_computer_link')
end

Expand Down
1 change: 0 additions & 1 deletion tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
"app/javascript/packs/pw-strength.js",
"app/javascript/packs/saml-post.js",
"app/javascript/packs/ssn-field.js",
"app/javascript/packs/upload-step.js",
"app/javascript/packs/webauthn-authenticate.js",
"app/javascript/packs/webauthn-setup.js",
"app/javascript/packs/webauthn-unhide.js"
Expand Down