Skip to content

Remove liveness methods from the Profile model #7264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmhooper merged 2 commits into from
Nov 1, 2022
Merged

Remove liveness methods from the Profile model #7264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0681c3c
Remove liveness methods from the Profile model
jmhooper Nov 1, 2022
d25d2ff
whoops
jmhooper Nov 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions app/models/profile.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,21 +90,11 @@ def self.build_compound_pii(pii)
values.join(':')
end

def includes_liveness_check?
return false if proofing_components.blank?
proofing_components['liveness_check'].present?
end

def includes_phone_check?
return false if proofing_components.blank?
proofing_components['address_check'] == 'lexis_nexis_address'
end

def strict_ial2_proofed?
return false unless active
includes_liveness_check?
end

def has_proofed_before?
Profile.where(user_id: user_id).where.not(activated_at: nil).where.not(id: self.id).exists?
end
Expand Down
42 changes: 0 additions & 42 deletions spec/models/profile_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,26 +46,6 @@
end
end

describe '#includes_liveness_check?' do
it 'returns true if a component for liveness is present' do
profile = create(:profile, proofing_components: { liveness_check: 'acuant' })

expect(profile.includes_liveness_check?).to eq(true)
Copy link
Copy Markdown
Contributor

@zachmargolis zachmargolis Nov 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are changes to the model file itself missing?

Copy link
Copy Markdown
Contributor Author

@jmhooper jmhooper Nov 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh, yes they are. idk how i managed to not check those in

end

it 'returns false if a component for liveness is not present' do
profile = create(:profile, proofing_components: { liveness_check: nil })

expect(profile.includes_liveness_check?).to eq(false)
end

it 'returns false if proofing_components is blank' do
profile = create(:profile, proofing_components: '')

expect(profile.includes_liveness_check?).to eq(false)
end
end

describe '#includes_phone_check?' do
it 'returns true if the address_check component is lexis_nexis_address' do
profile = create(:profile, proofing_components: { address_check: 'lexis_nexis_address' })
Expand All @@ -86,28 +66,6 @@
end
end

describe '#strict_ial2_proofed?' do
it 'returns false if the profile is not active' do
profile = create(:profile, active: false)

expect(profile.strict_ial2_proofed?).to eq(false)
end

it 'returns true if the profile does have liveness' do
proofing_components = { liveness_check: :acuant }
profile = create(:profile, :active, proofing_components: proofing_components)

expect(profile.strict_ial2_proofed?).to eq(true)
end

it 'returns false if the profile does not have liveness' do
proofing_components = { liveness_check: nil }
profile = create(:profile, :active, proofing_components: proofing_components)

expect(profile.strict_ial2_proofed?).to eq(false)
end
end

describe '#encrypt_pii' do
subject(:encrypt_pii) { profile.encrypt_pii(pii, user.password) }

Expand Down