Skip to content

Guard defining ComponentPreviewController on feature flag #7200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zachmargolis merged 7 commits into from
Oct 24, 2022
Merged

Guard defining ComponentPreviewController on feature flag #7200

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c08bcd6
Guard defining ComponentPreviewController on feature flag
zachmargolis Oct 24, 2022
d74de65
Add changelog
zachmargolis Oct 24, 2022
7ed4d9d
add explanatory comment
zachmargolis Oct 24, 2022
5603a0a
Add stub class so Zeitwerk doesn't complain about the file not defini…
zachmargolis Oct 24, 2022
5031d89
Switch around conditions
zachmargolis Oct 24, 2022
430f3c3
Update app/controllers/component_preview_controller.rb
zachmargolis Oct 24, 2022
1663bde
Make these conditional too
zachmargolis Oct 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions app/controllers/component_preview_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
class ComponentPreviewController < ViewComponentsController
include ActionView::Helpers::AssetTagHelper
helper Lookbook::PreviewHelper
include Lookbook::PreviewController
include ScriptHelper
if IdentityConfig.store.component_previews_enabled
include ActionView::Helpers::AssetTagHelper
helper Lookbook::PreviewHelper
include Lookbook::PreviewController
include ScriptHelper
Comment thread
zachmargolis marked this conversation as resolved.

helper_method :enqueue_component_scripts
alias_method :enqueue_component_scripts, :render_javascript_pack_once_tags
helper_method :enqueue_component_scripts
alias_method :enqueue_component_scripts, :render_javascript_pack_once_tags
end
end