Add explicit alg: param to JWE encryption#7178
Merged
zachmargolis merged 1 commit intomainfrom Oct 19, 2022
Merged
Conversation
**Why**: This was implicitly the default already, and making it explicit helps clarify that this is asymmetric encryption (because the enc: is symmetric) [skip changelog]
zachmargolis
commented
Oct 19, 2022
Comment on lines
+35
to
+38
| header_str, *_rest = JWE::Serialization::Compact.decode(jwe) | ||
| headers = JSON.parse(header_str) | ||
|
|
||
| expect(headers['alg']).to eq('RSA-OAEP') |
Contributor
Author
There was a problem hiding this comment.
this test would have passed before the PR, I'm just adding it as a regression catch now
mitchellhenke
approved these changes
Oct 19, 2022
n1zyy
reviewed
Oct 19, 2022
Contributor
n1zyy
left a comment
n1zyy
left a comment
There was a problem hiding this comment.
As someone who was wrong on a client call today, confusing AES with RSA, strong ➕ to making this explicit here. 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
N/A
🛠 Summary of changes
Why: This was implicitly the default already, and making it explicit helps clarify that this is asymmetric encryption (because the enc: is symmetric)