Skip to content

Set va_inherited_proofing_mock_enabled true for development environments#7172

Merged
gangelo merged 1 commit intomainfrom
turn-va-inherited-proofing-mock-enabled-to-true-in-development-environment
Oct 19, 2022
Merged

Set va_inherited_proofing_mock_enabled true for development environments#7172
gangelo merged 1 commit intomainfrom
turn-va-inherited-proofing-mock-enabled-to-true-in-development-environment

Conversation

@gangelo
Copy link
Contributor

@gangelo gangelo commented Oct 19, 2022

changelog: Internal, Inherited Proofing, Set va_inherited_proofing_mock_enabled true for development environments

This is so that developers do not have to specifically enable this switch - we should not be attempting to make live calls in our development environments by default.

🎫 Ticket

N/A

🛠 Summary of changes

Set va_inherited_proofing_mock_enabled to true in development environments.

This is so that developers do not have to specifically enable this switch - we should not be attempting to make live calls in our development environments by default.

📜 Testing Plan

  • Local development environment test.

👀 Screenshots

N/A

🚀 Notes for Deployment

N/A

changelog: Internal, Inherited Proofing, Turn va_inherited_proofing_mock_enabled true for development environments

This is so that developers do not have to specifically enable this
switch - we should not be attempting to make live calls in our
development environments by default.
@gangelo gangelo requested review from aduth and jmhooper October 19, 2022 15:29
@gangelo gangelo self-assigned this Oct 19, 2022
Copy link
Contributor

@holytoastr holytoastr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it

@gangelo gangelo merged commit cc1d917 into main Oct 19, 2022
@gangelo gangelo deleted the turn-va-inherited-proofing-mock-enabled-to-true-in-development-environment branch October 19, 2022 15:47
This was referenced Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants