Split design system navigation JavaScript to own pack#7170
Merged
Conversation
changelog: Internal, Performance, Reduce JavaScript bundle size in critical paths
This was referenced Oct 20, 2022
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Removes "navigation" from default set of design system JavaScript components, instead initializing only where applicable. The "navigation" JavaScript is concerned with the side navigation flyout menu at small viewports, but this navigation is only rendered as part of the
account_side_navlayout, which is not used in most critical paths (notably, sign in).The effect is a reduction of total JavaScript size of the sign in page of ~8.2% (71.7kb to 65.8kb, gzipped and minified).
📜 Testing Plan
Ensure that side navigation continues to work as expected where applicable (e.g. account dashboard at mobile viewports).