Ensure email belongs to account when resending email confirmation email#7164
Merged
mitchellhenke merged 2 commits intomainfrom Oct 18, 2022
Merged
Conversation
changelog: Bug Fixes, Emails, Ensure email belongs to account when resending email confirmation email
mitchellhenke
force-pushed
the
mitchellhenke/ensure-email-address-belongs-to-user
branch
from
cece0b8 to
50542cb
Compare
mitchellhenke
deleted the
mitchellhenke/ensure-email-address-belongs-to-user
branch
mitchellhenke
pushed a commit
that referenced
this pull request
Oct 18, 2022
…il (#7164) * Ensure email belongs to account when resending email confirmation email changelog: Bug Fixes, Emails, Ensure email belongs to account when resending email confirmation email * add analytics
This was referenced Oct 20, 2022
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Follow on to #7106 (and #7162) that addresses some user/email address mismatch issues around email resending. This PR ensures that the email address record we are using belongs to the current user. It is difficult to write a regression test for this since it depends partially on the database returning the incorrect record, which only happens some of the time.
This PR also adds analytics to the add email/resend email actions which did not exist previously.