LG-7449, Add first error page for inherited proofing when no information is received from API call.

[rnagilla-gsa]

🎫 Ticket

LG-7449
Link to the relevant ticket.

🛠 Summary of changes

1. Add first error page for inherited proofing when no information is received from API call for any reason
2. Removed unused phone html page and relevant translations.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

• Step 1
• Step 2
• Step 3

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.

Before:

After:

🚀 Notes for Deployment

Include any special instructions for deployment.

[aduth]

Should the "Try again" be going to a page for the user to try again, rather than the root URL?

[rnagilla-gsa]

@aduth Yes, that work(page which does asynchronous api call) is still in progress and this is a placeholder for now.

[aduth]

Even if there's no logic associated with the route, conventionally it's preferred to at least include an empty method for the action in the controller, so that it's more obvious what actions exist when looking at the controller implementation.

class InheritedProofingController
  # ...

  def no_information; end
end

[aduth]

I tried testing this locally by going directly to http://localhost:3000/verify/inherited_proofing/errors/no_information, only to see a 500 error undefined method uuid' for nil:NilClass`. It seems that we need to be adding some validation in the base controller to avoid 500.

[rnagilla-gsa]

@aduth I actually first added that method to controller and then removed it thinking that preferred. Ex. no_camera action on doc_auth/errors . I will re add it.

[rnagilla-gsa]

We have a future tasks for adding before_filters but I added before_action :confirm_two_factor_authenticated to redirect away from that

[aduth]

We should leave out this option so that the default :h2 heading is used, since otherwise there's an accessibility issue, as the heading order increases from h1 to h3.

https://dequeuniversity.com/rules/axe/3.5/heading-order

Suggested change

heading_tag: :h3,

[aduth]

There's only one option, and it's not conditional, so I don't think we need the filtering here.

Suggested change

	].select(&:present?),
	],

[aduth]

We may be able to resolve this issue by reordering the includes instead, since IdvSession is already checking that the user is authenticated, but it's not being reached since FlowStateMachine is where the error is happening.

Suggested change

	before_action :confirm_two_factor_authenticated
	include Flow::FlowStateMachine
	include IdvSession
	include IdvSession
	include Flow::FlowStateMachine

[aduth]

With a nested route like this, typically I'd expect this to be broken out to a separate controller, rather than funneling all the routes through a single controller (e.g. InheritedProofingErrorsController).

[rnagilla-gsa]

We probably will move this to the other ErrorController and Error handling work that Jeff is working on.

[aduth]

Can you link me to the related ticket which tracks that work?

[jscodefix]

@aduth The error handling methodology mentioned here, in this PR conversation, is being worked in LG-7257. You and I had a discussion about the implementation, on the 7th of this month; specifically about creating InheritedProofingErrorsController. I am waiting for this PR code to be merged, so that I can integrate the error controller.