Remove class-level puts statement from Attempts API rake task#7160
Merged
zachmargolis merged 1 commit intomainfrom Oct 18, 2022
Merged
Remove class-level puts statement from Attempts API rake task#7160zachmargolis merged 1 commit intomainfrom
zachmargolis merged 1 commit intomainfrom
Conversation
**Why**: in production, running one rake task causes them all to be loaded so this puts statement got executed from an unrelated task, because it was at the class level [skip changelog]
mitchellhenke
approved these changes
Oct 18, 2022
jmhooper
approved these changes
Oct 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[skip changelog]
🎫 Ticket
n/a
🛠 Summary of changes
In production, running one rake task causes them all to be loaded so this puts statement got executed from an unrelated task, because it was at the class level
📜 Testing Plan
irs_attempt_api_auth_tokens: ''locallybundle exec rake -T(list tasks)