Remove unreachable reference to secure_headers gem#7157
Merged
Conversation
changelog: Internal, Code Quality, Remove unreachable code
Avoid nested inline blocks, simplify diff
This was referenced Oct 20, 2022
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Removes unreachable code referencing the
secure_headersgem which had been removed in #6234.Reviewer note: Effectively this just removes the
add_document_capture_image_urls_to_csp_with_secure_headersmethod, but refactoring to collapse and rename the helper module and method name caused the git diff to present it as a brand new file.📜 Testing Plan