-
Notifications
You must be signed in to change notification settings - Fork 166
LG-7663 email analytics for success and failure emails #7156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
672b8b9
email analytics sent for success and failure emails
svalexander ed6c369
log email event for success version
svalexander f4d87c0
log event exists for failed email
svalexander bc8eea4
check email analytics are logged
svalexander 63ef137
update time param so tests pass
svalexander e1a68c2
Internal, Analytics, add email analytics
svalexander 41438e5
fix lint issues
svalexander c2ddd4b
change email version to type
svalexander 4d1bf11
remove wait time
svalexander 39f93aa
remove redundant email type
svalexander File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally
email_analytics_attributesseems to be a good candidate for a private method, since we're primarily concerned with each of the specific email types, and the helper method is an implementation detail that we could choose to refactor or remove altogether. As a private method, I don't think we'd need to test it at all in isolation like this, but I'd suggest enhancing the assertions below for the specific email types to ensure they include all the details we're looking for.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i separated out the email attributes from the earlier test for job analytics so I could use a completed enrollment rather then the pending enrollment used for the test for the other job analytics.