LG-7789: Update the International Phone Number Support help page#7154
Merged
LG-7789: Update the International Phone Number Support help page#7154
Conversation
jmdembe
commented
Oct 17, 2022
changelog: Internal, API improvements, add and update information for American Samoa and Northern Mariana Islands
jmdembe
force-pushed
the
LG-7789-update-international-number
branch
from
c8e9b64 to
c6b529c
Compare
Contributor
Yep, please do! I think we already disabled it on our side, so it shouldn't end up being different to end users. |
Contributor
Author
Sounds good. I'll make the update |
jmdembe
force-pushed
the
LG-7789-update-international-number
branch
from
0727a65 to
d7d3685
Compare
mitchellhenke
approved these changes
Oct 17, 2022
mdiarra3
pushed a commit
that referenced
this pull request
Oct 19, 2022
* Add info for American Samoa, edit info for Northern Mariana Islands changelog: Internal, API improvements, add and update information for American Samoa and Northern Mariana Islands * fix lint error * update information for Japan * revert `supports_sms` value for MP and AS * revert based on discussion * Revert "revert based on discussion" This reverts commit 2e696f8.
mdiarra3
added a commit
that referenced
this pull request
Oct 19, 2022
…) (#7175) * Add info for American Samoa, edit info for Northern Mariana Islands changelog: Internal, API improvements, add and update information for American Samoa and Northern Mariana Islands * fix lint error * update information for Japan * revert `supports_sms` value for MP and AS * revert based on discussion * Revert "revert based on discussion" This reverts commit 2e696f8. Co-authored-by: Jessica Dembe <jessica.dembe@gsa.gov>
This was referenced Oct 20, 2022
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-7789
🛠 Summary of changes
This ticket adds/updates the following information to the international countries list:
pinpoint_overrides.ymlOnce changed, the table for "International phone number support" will reflect the API change
📜 Testing Plan
?
👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
Before
After
🚀 Notes for Deployment
N/A