LG-7446 Create "Cancel" Links and Supporting Cancellation Code for Identity Proofing Process (2 of n)#7140
Closed
LG-7446 Create "Cancel" Links and Supporting Cancellation Code for Identity Proofing Process (2 of n)#7140
Conversation
The IdentityConfig.store.inherited_proofing_enabled returns false in preparation for use in the Inherited Proofing (IP) cancellations controller that needs to be created. Eventually, this code may get thrown away once IP goes live; however, this makes for less lines of code that need to be removed once/if it does. changelog: Improvements, Upcoming Features, LG-7446 Create Inherited Proofing Cancellation Links and Process
Specs to be added in subsequent PR when controller actions are fleshed out.
Specifically, the "Render path contains parameter value" violation.
This commit whitelists the flow steps expected and raises an error
if params[:step] is not found in the whitelist.
Confidence: Weak
Category: Dynamic Render Path
Check: Render
Message: Render path contains parameter value
Code: render(action => ButtonComponent.new(:action =>
(lambda do button_to(idv_inherited_proofing_cancel_path(:step => params[:step]),
{ **tag_options }, &block) end), :method => :put, :big => true, :wide => true,
:outline => true).with_content(t("inherited_proofing.cancel.actions.keep_going")), {})
File: app/views/idv/inherited_proofing_cancellations/new.html.erb
Line: 23
Confidence: Weak
Category: Dynamic Render Path
Check: Render
Message: Render path contains parameter value
Code: render(action => SpinnerButtonComponent.new(:action =>
(lambda do button_to(idv_inherited_proofing_cancel_path(:step => params[:step],
:location => "cancel"), { **tag_options }, &block) end), :method => :delete,
:big => true, :wide => true, :outline => true,
:form => ({ :data => ({ :form_steps_wait => "" }) }))
.with_content(CancellationsPresenter.new(:sp_name =>
decorated_session.sp_name, :url_options => url_options).exit_action_text), {})
File: app/views/idv/inherited_proofing_cancellations/new.html.erb
Line: 44
gangelo
added
the
inherited proofing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See PR LG-7446 Create "Cancel" Links and Supporting Cancellation Code for Identity Proofing Process (1 of n)
🎫 Ticket
LG-7446
🛠 Summary of changes
NOTE: This is feature branch 2 of what most likely be (at most) several feature branches.
In this feature branch:
In subsequent feature branch(es):
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
👀 Screenshots
TODO
🚀 Notes for Deployment
See PR LG-7446 Create "Cancel" Links and Supporting Cancellation Code for Identity Proofing Process (1 of n)