Skip to content

LG-7724: set va_inherited_proofing_mock_enabled default value to false for all environments #7127

Merged
rnagilla-gsa merged 3 commits intomainfrom
rrn/LG-7724
Oct 17, 2022
Merged

LG-7724: set va_inherited_proofing_mock_enabled default value to false for all environments #7127
rnagilla-gsa merged 3 commits intomainfrom
rrn/LG-7724

Conversation

@rnagilla-gsa
Copy link
Contributor

🎫 Ticket

LG-7724

🛠 Summary of changes

  1. set va_inherited_proofing_mock_enabled default value to false for all environments.
    Write a brief description of what you changed.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Step 1
  • Step 2
  • Step 3

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.

Before:
After:

🚀 Notes for Deployment

Include any special instructions for deployment.

Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

in_person_proofing_enabled: true
inherited_proofing_enabled: true
va_inherited_proofing_mock_enabled: true
va_inherited_proofing_mock_enabled: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this override value is the same as the default, we could just remove it altogether.

Suggested change
va_inherited_proofing_mock_enabled: false

@rnagilla-gsa rnagilla-gsa added the inherited proofing Pull Requests for the Inherited Proofing feature label Oct 13, 2022
@rnagilla-gsa rnagilla-gsa merged commit 77adb3a into main Oct 17, 2022
@rnagilla-gsa rnagilla-gsa deleted the rrn/LG-7724 branch October 17, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inherited proofing Pull Requests for the Inherited Proofing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants