Update ThreatMetrixJsVerificationJob#7126
Merged
zachmargolis merged 4 commits intomainfrom Oct 18, 2022
Merged
Conversation
- It always logs something after each run, so that we can get better info on why it bails early, if it does [skip changelog]
Co-authored-by: Andrew Duthie <aduth@users.noreply.github.com>
aduth
approved these changes
Oct 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
N/A
🛠 Summary of changes
Currently the job will early return and log nothing in a bunch of cases where it could be misconfigured. This updates the job to always logs something after each run, so that we can get better info on why it bails early, if it does.
Related: https://github.com/18F/identity-devops/pull/5320
I updated it to remove the
validkey unless we had an explicit result, so that hopefully misconfigured runs would not trip the alert above.📜 Testing Plan