Skip to content

Remove unused FSMv2 analytics event mapping #7110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 1 commit into from
Oct 7, 2022
Merged

Remove unused FSMv2 analytics event mapping #7110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions app/controllers/frontend_log_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,23 +13,11 @@ class FrontendLogController < ApplicationController
'IdV: prepare submitted' => :idv_in_person_prepare_submitted,
'IdV: switch_back visited' => :idv_in_person_switch_back_visited,
'IdV: switch_back submitted' => :idv_in_person_switch_back_submitted,
'IdV: forgot password visited' => :idv_forgot_password,
'IdV: password confirm visited' => :idv_review_info_visited,
'IdV: password confirm submitted' => proc do |analytics|
analytics.idv_review_complete(success: true)
analytics.idv_final(success: true)
end,
'IdV: personal key visited' => :idv_personal_key_visited,
'IdV: personal key submitted' => :idv_personal_key_submitted,
'IdV: personal key confirm visited' => :idv_personal_key_confirm_visited,
'IdV: personal key confirm submitted' => :idv_personal_key_confirm_submitted,
'IdV: download personal key' => :idv_personal_key_downloaded,
'IdV: Native camera forced after failed attempts' => :idv_native_camera_forced,
'Multi-Factor Authentication: download backup code' => :multi_factor_auth_backup_code_download,
'Show Password button clicked' => :show_password_button_clicked,
}.transform_values do |method|
method.is_a?(Proc) ? method : AnalyticsEvents.instance_method(method)
end.freeze
}.transform_values { |method| AnalyticsEvents.instance_method(method) }.freeze
# rubocop:enable Layout/LineLength

def create
Expand Down
17 changes: 2 additions & 15 deletions spec/controllers/frontend_log_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,12 @@
end

context 'allowlisted analytics event' do
let(:event) { 'IdV: personal key visited' }
let(:event) { 'IdV: download personal key' }

it 'succeeds' do
action

expect(fake_analytics).to have_logged_event('IdV: personal key visited')
expect(fake_analytics).to have_logged_event('IdV: personal key downloaded')
expect(response).to have_http_status(:ok)
expect(json[:success]).to eq(true)
end
Expand Down Expand Up @@ -71,19 +71,6 @@
end
end

context 'allowlisted analytics event with compound proc' do
let(:event) { 'IdV: password confirm submitted' }

it 'succeeds' do
action

expect(fake_analytics).to have_logged_event('IdV: review complete')
expect(fake_analytics).to have_logged_event('IdV: final resolution', success: true)
expect(response).to have_http_status(:ok)
expect(json[:success]).to eq(true)
end
end
Comment on lines -74 to -85
Copy link
Contributor

@zachmargolis zachmargolis Oct 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! glad we could remove this special case


context 'empty payload' do
let(:payload) { {} }

Expand Down