-
Notifications
You must be signed in to change notification settings - Fork 167
Revise headers and instructions #709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,39 +1,39 @@ | ||
| en: | ||
| headings: | ||
| confirmations: | ||
| new: Resend confirmation instructions | ||
| new: Send another confirmation email | ||
| contact: Contact us | ||
| create_account_with_sp: Make a login.gov account to continue to %{sp} | ||
| create_account_without_sp: Make a login.gov account | ||
| create_account_with_sp: Create a login.gov account to continue to %{sp} | ||
| create_account_without_sp: Create a login.gov account | ||
| edit_info: | ||
| email: Edit your email | ||
| password: Edit your password | ||
| phone: Edit your phone number | ||
| email: Change your email | ||
| password: Change your password | ||
| phone: Change your phone number | ||
| log_in: Sign in | ||
| log_in_branded: Sign in to continue to %{sp} | ||
| choose_otp_delivery: Choose delivery method | ||
| sign_in_branded: Sign in to continue to %{sp} #question about variable names -- "_branded" vs _"w_with_SP"? | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For consistency, these should probably be
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @monfresh I really want to close this PR -- file and issue ad do a pass at this later?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sounds good. I was just responding to your comment on line 13. |
||
| choose_otp_delivery: Choose how you'd like to receive a one-time passcode | ||
| passwords: | ||
| change: Change your password | ||
| forgot: Forgot password | ||
| confirm: Confirm your password | ||
| forgot: Forget your password? #why is this here and not in links/en.yml? | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is used as a link in the UI -- I think. Should it be in links/en.yml?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is used as both the header on this page: https://idp.demo.login.gov/users/password/new, as well as a link on the home page. If they need to be different, then yes, we should add an entry in the links section. Also, shouldn't this be "Forgot your password?" instead of "Forget your password?". |
||
| confirm: Confirm your password to continue | ||
| privacy_policy: | ||
| privacy_act: Privacy Act Statement | ||
| security_practices: Our Security Practices | ||
| privacy_practices: Our Privacy Practices | ||
| privacy_act: Privacy Act statement | ||
| security_practices: Our security practices | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Resolved as per our styleguide |
||
| privacy_practices: Our privacy practices | ||
| authorities: Authorities | ||
| purpose: Purpose | ||
| disclosure: Disclosure | ||
| routine_uses: Routine Uses | ||
| routine_uses: Routine uses | ||
| more_information: For more information | ||
| profile: | ||
| profile_info: Profile information | ||
| profile_info_tt: Why can’t I edit my profile information? | ||
| account_history: Account history | ||
| login_info: Login information | ||
| login_info: Account information | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @jeanninehunter Changed for greater consistency in headers. Also because we decided to use "sign in" and not "log in"...and "Sign-in information" just didn't sound right. |
||
| two_factor: Two-factor authentication | ||
| recovery_code: Make sure you can always log in, even without your phone | ||
| recovery_code: Make sure you can always sign in | ||
| registrations: | ||
| enter_email: Start making your account | ||
| enter_email: Start creating an account | ||
| verify_email: Check your email | ||
| search: Search for a user | ||
| session_timeout_warning: Session timeout | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,8 @@ | ||
| en: | ||
| instructions: | ||
| recovery_code: > | ||
| You can still log in using a special recovery code if you can’t get to | ||
| your phone. | ||
| Write this recovery code down and store it someplace safe. If you can't get to your phone, | ||
| you can use it instead of a one-time passcode to sign in. | ||
| password: | ||
| info: | ||
| lead: Your password must be at least %{min_length} characters long. | ||
|
|
@@ -21,13 +21,13 @@ en: | |
| iv: Good | ||
| v: Great! | ||
| registration: | ||
| already_have_account: Already have account? %{link} | ||
| already_have_account: Already have an account? %{link} | ||
| email: Pick an address to use for government communications. | ||
| 2fa: | ||
| resend: Didn’t receive a code? %{link} | ||
| confirm_code: We sent the code to %{number}. | ||
| confirm_code: We sent it to %{number}. | ||
| wrong_number: Entered the wrong phone number? %{link} | ||
| totp_intro_html: > | ||
| Please enter the code from your authenticator app. | ||
| Enter the code from your authenticator app. | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed all the "pleases" as per http://www.ihearttechnicalwriting.com/write-error-messages/. Which maybe @jeanninehunter will disagree with 😨 |
||
| If you have several accounts set up in your app, enter the code | ||
| corresponding to <strong>%{email}</strong> at <strong>%{app}</strong>. | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@monfresh What next steps can we offer a user who (perhaps) had a typo in a recovery code? Obvs we can suggest that the user check that they correctly typed in the code and try again...anything else? Best practices in error message writing say that we should give some next steps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't think of anything else. Here is Apple's support article on the subject for any ideas: https://support.apple.com/en-us/HT202649