Skip to content

Event standardization work #7059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThatSpaceGuy merged 1 commit into from
Sep 29, 2022
Merged

Event standardization work #7059

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions app/services/irs_attempts_api/tracker_events.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ module TrackerEvents
# @param [Boolean] success True if Account Successfully Deleted
# @param [Hash<Key, Array<String>>] failure_reason displays why account deletion failed
# A User confirms and deletes their Login.gov account after 24 hour period
def account_reset_account_deleted(success:, failure_reason:)
def account_reset_account_deleted(success:, failure_reason: nil)
track_event(
:account_reset_account_deleted,
success: success,
Expand Down Expand Up @@ -140,7 +140,7 @@ def idv_document_upload_submitted(
# @param [Boolean] success
# @param [Hash<Key, Array<String>>] failure_reason displays GPO submission failed
# GPO verification submitted from Letter sent to verify address
def idv_gpo_verification_submitted(success:, failure_reason:)
def idv_gpo_verification_submitted(success:, failure_reason: nil)
track_event(
:idv_gpo_verification_submitted,
success: success,
Expand Down Expand Up @@ -190,7 +190,7 @@ def idv_personal_key_generated(success:)
# @param [Hash<Key, Array<String>>] failure_reason
# Track when OTP is sent and what method chosen during idv flow.
def idv_phone_confirmation_otp_sent(success:, phone_number:,
otp_delivery_method:, failure_reason:)
otp_delivery_method:, failure_reason: nil)
track_event(
:idv_phone_confirmation_otp_sent,
success: success,
Expand Down Expand Up @@ -615,7 +615,7 @@ def mfa_login_webauthn_roaming(success:)
# Tracks when user has entered personal key after forgot password steps
# @param [Boolean] success
# @param [Hash<Symbol,Array<Symbol>>] failure_reason
def personal_key_reactivation_submitted(success:, failure_reason:)
def personal_key_reactivation_submitted(success:, failure_reason: nil)
track_event(
:personal_key_reactivation_submitted,
success: success,
Expand Down