Skip to content

Log 2FA Setup Complete Event when skipping adding additional MFA #7056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchellhenke merged 1 commit into from
Sep 29, 2022
Merged

Log 2FA Setup Complete Event when skipping adding additional MFA #7056

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions app/controllers/mfa_confirmation_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,12 @@ def skip
user_session.delete(:mfa_selections)
user_session.delete(:next_mfa_selection_choice)
analytics.user_registration_suggest_another_mfa_notice_skipped
analytics.user_registration_mfa_setup_complete(
mfa_method_counts: mfa_context.enabled_two_factor_configuration_counts_hash,
enabled_mfa_methods_count: mfa_context.enabled_mfa_methods_count,
pii_like_keypaths: [[:mfa_method_counts, :phone]],
success: true,
)
redirect_to after_mfa_setup_path
end

Expand Down Expand Up @@ -64,4 +70,8 @@ def handle_max_password_attempts_reached
sign_out
redirect_to root_url, flash: { error: t('errors.max_password_attempts_reached') }
end

def mfa_context
@mfa_context ||= MfaContext.new(current_user)
end
end