Skip to content

LG-7150 add login icon alt text #7023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svalexander merged 7 commits into from
Sep 26, 2022
Merged

LG-7150 add login icon alt text #7023

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
259064d
update alt tag to login.gov logo
svalexander Sep 22, 2022
b2931a2
update user_mailer.html spec to include text for img alt text
svalexander Sep 22, 2022
d30f322
[skip changelog]
svalexander Sep 23, 2022
48b08dd
use var
svalexander Sep 23, 2022
93097e8
move alt text to i18l files
svalexander Sep 26, 2022
0d95ea5
update spec
svalexander Sep 26, 2022
05a2067
update untranslated keys
svalexander Sep 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/views/layouts/user_mailer.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
attachments['logo.png'].url,
size: '142x19',
style: 'width: 142px; height: 19px;',
alt: t('mailer.logo', app_name: APP_NAME),
) %>
</th>
<th class="expander"></th>
Expand Down
1 change: 1 addition & 0 deletions config/locales/mailer/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,6 @@ en:
email_reuse_notice:
subject: This email address is already associated with an account.
help: If you need help, visit %{link}
logo: '%{app_name} logo'
no_reply: Please do not reply to this message.
privacy_policy: Privacy policy
1 change: 1 addition & 0 deletions config/locales/mailer/es.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,6 @@ es:
email_reuse_notice:
subject: Este email ya está asociado a una cuenta.
help: Si necesita ayuda, visite %{link}
logo: '%{app_name} logo'
no_reply: Por favor, no responda a este mensaje.
privacy_policy: Póliza de privacidad
1 change: 1 addition & 0 deletions config/locales/mailer/fr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,6 @@ fr:
email_reuse_notice:
subject: Cette adresse courriel est déjà associée à un compte.
help: Si vous avez besoin d’aide, visitez le site %{link}
logo: '%{app_name} logo'
no_reply: Veuillez ne pas répondre à ce message.
privacy_policy: Politique de confidentialité
1 change: 1 addition & 0 deletions spec/i18n_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ class BaseTask
{ key: 'time.pm' }, # "PM" is "PM" in French and Spanish
{ key: 'datetime.dotiw.minutes.one' }, # "minute is minute" in French and English
{ key: 'datetime.dotiw.minutes.other' }, # "minute is minute" in French and English
{ key: 'mailer.logo' }, # "logo is logo" in English, French and Spanish
].freeze
# rubocop:enable Layout/LineLength

Expand Down
4 changes: 4 additions & 0 deletions spec/views/layouts/user_mailer.html.erb_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@
expect(rendered).to have_css("img[src*='.mail']")
end

it 'includes alt text for app logo that reads Login.gov logo' do
expect(rendered).to have_css("img[alt='#{t('mailer.logo', app_name: APP_NAME)}']")
end

it 'includes the message subject in the body' do
expect(rendered).to have_content @mail.subject
end
Expand Down