Skip to content

Deploy RC 211 to Production#6997

Merged
mitchellhenke merged 19 commits intostages/prodfrom
stages/rc-2022-09-22
Sep 22, 2022
Merged

Deploy RC 211 to Production#6997
mitchellhenke merged 19 commits intostages/prodfrom
stages/rc-2022-09-22

Conversation

@mitchellhenke
Copy link
Contributor

@mitchellhenke mitchellhenke commented Sep 21, 2022

Bug Fixes

  • Authentication: Replace id_token_hint with client_id (#6936)

Internal

  • Attempts API: Standardize events name (#6992)
  • Attempts API: Fixes log_reproof_event (#6982)
  • Automated Testing: Improve developer experience for writing interaction tests (#6995)
  • Dependencies: Update Rails (#7000)
  • Document Capture: Set up A/B testing for native camera vs Acuant SDK (#6915)
  • Inherited Proofing: Adding basic Please Verify UI (#6988)
  • Performance: Cache phone_configuration queries during OTP authentication (#6998)
  • Performance: Only fetch all email addresses when requested for OIDC user info (#6999)
  • ThreatMetrix API: Allow non-PII fields (#6993)

Upcoming Features

  • In-person proofing: Normalize arguments (#6987)

orenyk and others added 13 commits September 19, 2022 21:26
Resolves LG-7433

**Why:** We don't want partners sending us ID tokens as query
parameters. We initially permit both client_id and id_token_hint, but
also include two feature flags so that we can extend the rollout of both
support for client_id as well as the deprecation of id_token_hint
through the sandbox.

changelog: Bug Fixes, Authentication, Replace id_token_hint with
client_id in OIDC logout
Why:
Inherited Proofing users will need to verify that the information we receive from the partner organization is correct

changelog: Internal, Inherited Proofing, Adding basic Please Verify UI
* LG-7152: Setting up A/B testing for native camera vs Acuant SDK

changelog: Internal, Document Capture, Set up A/B testing for native camera vs Acuant SDK

* include a feature flag to enable/disable test completely
* first cut at AbTestBucket
* flesh out AbTestBucket
* apply the AbTestBucket to the DocumentCaptureStep
* Pull the specifics around this A/B test into its own class.
* Log the bucket in the image upload vendor submitted event.
* use a fully deterministic spec to test bucket distribution
* check for nativeCameraOnly as part of shouldStartAcuantCapture
* adds the name of the experiment to the percent generator
* better logic on when to block SDK for A/B test
* adds a spec for the native camera A/B test
**Why:**
- We were sometimes passing Pii::Attribute structs and other times
passing hashes to this function. While it wasn't causing a problem now
it is confusing

changelog: Upcoming Features, In-person proofing, Normalize arguments
for creating an enrollment
changelog: Internal, Attempts API, Fixes log_reproof_event
…6956)

* LG-7364 Return specific attributes that fail from LexisNexis proofer

This commit aims to refactor the LexisNexis proofer to user a plain old ruby object and to have it return specifically which attributes fail if only certain attributes fail

* i can't even write psuedocode

* still cannot code

* add failing specs for the proofer

* put resolution job back the way we found it for now

* [skip changelog]

* make the lexisnexis proofer look like the phonefinder one

* get started on the mock proofer

* get mock proofer resolution client passing

* start mapping checks to attributes

* User proofer_result directly

* Punt on merging with state_id_proofer result

* Punt on mutating the callback_log_data result

* Punt on context field and other proofer results

* Group transaction_id and reference with other fields and mark TODO field

* Test expected fields in turn

* Group fields and mark TODO context field

* Test fields in turn

* Group and mark TODO

* Group and mark TODO

* Test fields in turn

* Test fields in turn

* Consolidate different result hash logic

* use match instead of eq

* some things passing and some things failing

* example of how to fix nomethoderror

* Defer when resolution result is only a proofer result

* Implement methods on proofing result class

* Test result fields in turn

* Rename local variable name

* Rename threatmetrix entities

* Add back resolution tests

* Test result fields in turn

* Test expected value directly

* Test threatmetrix disabled

* Test lexisnexis failure response

* Restore threatmetrix nil response test

* Consolidate logic

* Improve format

* Improve format

* Test against result hash methods

* delint

* spec cleanup

* state id result is not quite ready

* clean up agent spec

* Define first_name on pii test object

* delint

Co-authored-by: Kimball Bighorse <kbighorse@yahoo.com>
changelog: Internal, Attempts API, Standardize events name
* Allow logging of emailage fields including confidence scores

* changelog: Internal, ThreatMetrix API, allow non-PII fields
changelog: Internal, Performance, Only fetch all email addresses when requested for OIDC user info
* Add ESLint enforcement of awaited userEvent

**Why**: Avoid developer confusion associated with race conditions caused by not properly awaiting the completion of a userEvent interaction.

changelog: Internal, Automated Testing, Improve developer experience for writing interaction tests

* Refactor password reset button spec to avoid Mocha "done" API

* Refactor PasswordResetButton spec to use Chai promise helprs
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zachmargolis and others added 6 commits September 21, 2022 10:17
- Move to initializer so we're not constantly re-allocating and checking
- Remove ActiveModel::Model, it was only half-used
- Update DocAuthRouter to use buckets

* Update document_capture_step spec and create new FakeAbTestBucket

[skip changelog]

Co-authored-by: Doug Price <douglas.price@gsa.gov>
* Update Rails

changelog: Internal, Dependencies, Update Rails

* Fix patched behavior for redirects and unsafe redirects
changelog: Internal, Performance, Cache phone_configuration queries during OTP authentication
* Handle zip+0 at GPO verification letter export

[skip changelog]
@mitchellhenke mitchellhenke merged commit f701c50 into stages/prod Sep 22, 2022
@mitchellhenke mitchellhenke deleted the stages/rc-2022-09-22 branch September 22, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.