Improve speed of VerifySpAttributesConcern#6921
Merged
mitchellhenke merged 2 commits intomainfrom Sep 6, 2022
Merged
Conversation
20b2425 to
a8877b1
Compare
zachmargolis
reviewed
Sep 6, 2022
zachmargolis
approved these changes
Sep 6, 2022
Contributor
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM, another good find!
changelog: Internal, Performance, Improve speed of VerifySpAttributesConcern
d40be4b to
8d40b3c
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
VerifySpAttributesConcernmakes repeated calls tosp_session_identity. The database call is cached after the first call, but there is still a noticeable amount of overhead in doing that.This PR cleans up the behavior to only maybe hit the database once and passes the result to the functions that follow.
Performance benchmark available in commit b924b5a