Merged
Conversation
matthinz
reviewed
Sep 2, 2022
| fuzzy_device_score | ||
| fuzzy_device_worst_score | ||
| http_connection_type | ||
| http_referer |
Contributor
There was a problem hiding this comment.
I think we should avoid logging referer if we can? It's not explicitly PII but kind of could be, some times?
Contributor
There was a problem hiding this comment.
It should only be our own pages right?
Contributor
Author
There was a problem hiding this comment.
The http_referer field I'm getting back from LN appears to contain an encoded or encrypted value, which is not what I was expecting. I'm removing it because I'm uncertain what it represents.
matthinz
reviewed
Sep 2, 2022
| session_id | ||
| session_id_query_count | ||
| summary_risk_score | ||
| time_zone |
Contributor
There was a problem hiding this comment.
This just made me Google "least populated time zones" to see if there would be a way to identify an individual by their time zone. (Answer: no)
zachmargolis
approved these changes
Sep 2, 2022
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
Seems like a good list to me!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.