Skip to content

Lg 7098 phone upload link submit #6908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThatSpaceGuy merged 8 commits into from
Sep 2, 2022
Merged

Lg 7098 phone upload link submit #6908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f29342f
LG-7098-Phone-upload-link-submit
ThatSpaceGuy Sep 1, 2022
0028dec
Better formatting
ThatSpaceGuy Sep 1, 2022
981e669
Refactor
ThatSpaceGuy Sep 1, 2022
e1019b0
Lint fix
ThatSpaceGuy Sep 1, 2022
f78c996
error fix
ThatSpaceGuy Sep 1, 2022
1f9c178
PR comments
ThatSpaceGuy Sep 1, 2022
944e3ac
spec fix
ThatSpaceGuy Sep 1, 2022
44f09bc
LG-7098 Remove unnecessary attributes from phone_upload_link_sent
ThatSpaceGuy Sep 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions app/controllers/idv/capture_doc_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,7 @@ def return_to_sp
private

def track_index_loads
irs_attempts_api_tracker.idv_phone_upload_link_used(
document_capture_session: document_capture_session_uuid,
request_id: request_id,
)
irs_attempts_api_tracker.idv_phone_upload_link_used
end

def ensure_user_id_in_session
Expand Down
12 changes: 2 additions & 10 deletions app/services/irs_attempts_api/tracker_events.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,18 +196,10 @@ def idv_phone_upload_link_sent(
)
end

# @param [String] document_capture_session
# The document_capture_session included with the phone upload link used
# @param [String] request_id
# The request_id included with the phone upload link used
def idv_phone_upload_link_used(
document_capture_session:,
request_id:
)
# The user has used a phone_upload_link to upload docs on their mobile device
def idv_phone_upload_link_used
track_event(
:idv_phone_upload_link_used,
document_capture_session: document_capture_session,
request_id: request_id,
)
end

Expand Down
20 changes: 5 additions & 15 deletions spec/controllers/idv/capture_doc_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,7 @@
it 'redirects to the root url' do
get :index

expect(@irs_attempts_api_tracker).to have_received(:idv_phone_upload_link_used).with(
{ document_capture_session: nil, request_id: '' },
)
expect(@irs_attempts_api_tracker).to have_received(:idv_phone_upload_link_used)

expect(response).to redirect_to root_url
end
Expand All @@ -47,9 +45,7 @@
it 'redirects to the root url' do
get :index, params: { 'document-capture-session': 'foo' }

expect(@irs_attempts_api_tracker).to have_received(:idv_phone_upload_link_used).with(
{ document_capture_session: 'foo', request_id: '' },
)
expect(@irs_attempts_api_tracker).to have_received(:idv_phone_upload_link_used)

expect(response).to redirect_to root_url
end
Expand All @@ -61,9 +57,7 @@
get :index, params: { 'document-capture-session': session_uuid }
end

expect(@irs_attempts_api_tracker).to have_received(:idv_phone_upload_link_used).with(
{ document_capture_session: session_uuid, request_id: '' },
)
expect(@irs_attempts_api_tracker).to have_received(:idv_phone_upload_link_used)

expect(response).to redirect_to root_url
end
Expand All @@ -73,9 +67,7 @@
it 'redirects to the first step' do
get :index, params: { 'document-capture-session': session_uuid }

expect(@irs_attempts_api_tracker).to have_received(:idv_phone_upload_link_used).with(
{ document_capture_session: session_uuid, request_id: '' },
)
expect(@irs_attempts_api_tracker).to have_received(:idv_phone_upload_link_used)

expect(response).to redirect_to idv_capture_doc_step_url(step: :document_capture)
end
Expand All @@ -86,9 +78,7 @@
mock_session(user.id)
get :index

expect(@irs_attempts_api_tracker).to have_received(:idv_phone_upload_link_used).with(
{ document_capture_session: nil, request_id: '' },
)
expect(@irs_attempts_api_tracker).to have_received(:idv_phone_upload_link_used)

expect(response).to redirect_to idv_capture_doc_step_url(step: :document_capture)
end
Expand Down