Skip to content

Update IPP flow to include CSP for ThreatMetrix#6901

Merged
matthinz merged 1 commit intomainfrom
matthinz/lg-7410-ipp-tmx-csp
Sep 1, 2022
Merged

Update IPP flow to include CSP for ThreatMetrix#6901
matthinz merged 1 commit intomainfrom
matthinz/lg-7410-ipp-tmx-csp

Conversation

@matthinz
Copy link
Contributor

@matthinz matthinz commented Sep 1, 2022

This is a follow-on to #6877, just ensuring that CSP headers are set properly on the SSN page for the In-Person Proofing flow to allow the ThreatMetrix javascript to run (when enabled).

[skip changelog]

This is a follow-on to #6877, just ensuring that CSP headers are set properly on the SSN page for the In-Person Proofing flow to allow the ThreatMetrix javascript to run (when enabled).

[skip changelog]
@matthinz matthinz requested review from a team and eileen-nava September 1, 2022 18:30
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we add regression specs for this? spec/requests specs are where we've ensured CSP headers before

@matthinz
Copy link
Contributor Author

matthinz commented Sep 1, 2022

I'm not seeing a quick way to do a regression spec here--this page is deep in the idv flow, so you need an active account to do the request in the first place.

@zachmargolis
Copy link
Contributor

I'm not seeing a quick way to do a regression spec here--this page is deep in the idv flow, so you need an active account to do the request in the first place.

ok! thanks for checking

@matthinz matthinz merged commit 12702b5 into main Sep 1, 2022
@matthinz matthinz deleted the matthinz/lg-7410-ipp-tmx-csp branch September 1, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants