Do not allow confirming email addresses via add email controller for unconfirmed accounts#6897
Merged
mitchellhenke merged 1 commit intomainfrom Sep 1, 2022
Conversation
Contributor
|
Per failing build, you might need to rebase this to pull in changes from #6893. |
mitchellhenke
force-pushed
the
mitchellhenke/do-not-confirm-emails-for-unconfirmed-accounts-in-add-email-controller
branch
from
24d7c84 to
091f2a2
Compare
aduth
reviewed
Sep 1, 2022
Contributor
There was a problem hiding this comment.
Other methods in this class call methods on this return value without nil-safe operators. Do we need to update those, or add an early return somewhere?
Contributor
Author
There was a problem hiding this comment.
My understanding of the existing implementation is that email_address being nil is expected (as a failure condition). I think it returns nil when the token is not associated with an email address, and this change is mostly extending the cases where we'll return nil.
zachmargolis
reviewed
Sep 1, 2022
mitchellhenke
force-pushed
the
mitchellhenke/do-not-confirm-emails-for-unconfirmed-accounts-in-add-email-controller
branch
2 times, most recently
from
091f2a2 to
f6e4c3e
Compare
…unconfirmed accounts changelog: Bug Fixes, Email Confirmation, Do not allow confirming email addresses via add email controller for unconfirmed accounts
mitchellhenke
force-pushed
the
mitchellhenke/do-not-confirm-emails-for-unconfirmed-accounts-in-add-email-controller
branch
from
f6e4c3e to
b69ff0b
Compare
mitchellhenke
deleted the
mitchellhenke/do-not-confirm-emails-for-unconfirmed-accounts-in-add-email-controller
branch
mitchellhenke
pushed a commit
that referenced
this pull request
Sep 1, 2022
…unconfirmed accounts (#6897) changelog: Bug Fixes, Email Confirmation, Do not allow confirming email addresses via add email controller for unconfirmed accounts
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.