Skip to content

Address PR review comments for mailer image#6895

Merged
aduth merged 5 commits intomainfrom
aduth-6892-pr-comments
Sep 1, 2022
Merged

Address PR review comments for mailer image#6895
aduth merged 5 commits intomainfrom
aduth-6892-pr-comments

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Sep 1, 2022

Context:

Why:

  • We should remove all files which are unused
  • Optimizing images improves performance for end-users and git clone
  • The images/email directory exists for these sorts of email assets

**Why**: Improve end-user and git clone performance
**Why:** The directory exists for email assets like this, separate as a way to disincentivize their use outside email templates
@aduth aduth requested review from eric-gade and peggles2 September 1, 2022 13:52
changelog: Improvements, Email Notifications, Update Forgot Password message to include warning for pending identity verification
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduth aduth merged commit abfa05b into main Sep 1, 2022
@aduth aduth deleted the aduth-6892-pr-comments branch September 1, 2022 14:55
@zachmargolis zachmargolis mentioned this pull request Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants