Add safeguard tests to ensure IRS events are not stored in plaintext#6887
Merged
mitchellhenke merged 1 commit intomainfrom Aug 31, 2022
Merged
Conversation
…ts are not stored in plaintext
mitchellhenke
force-pushed
the
mitchellhenke/safeguard-tests-for-attempts-events-storage
branch
from
06b47b6 to
9c15c0e
Compare
mitchellhenke
deleted the
mitchellhenke/safeguard-tests-for-attempts-events-storage
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a small additional layer to safeguard against future changes to the API to alert us if we are ever storing events in plaintext in Redis. It also changes some of the event metadata in tests to be PII to be slightly more precise about the type of data stored. Using PII also helps in the controller specs since the session class will automatically fail if it detects plaintext PII