Skip to content

LG-7111: Idv Phone OTP Sent Rate Limited attempt event#6878

Merged
jc-gsa merged 4 commits intomainfrom
LG-7111-idv-phone-otp-sent-rate-limited
Sep 6, 2022
Merged

LG-7111: Idv Phone OTP Sent Rate Limited attempt event#6878
jc-gsa merged 4 commits intomainfrom
LG-7111-idv-phone-otp-sent-rate-limited

Conversation

@jc-gsa
Copy link
Contributor

@jc-gsa jc-gsa commented Aug 30, 2022

No description provided.

@jc-gsa jc-gsa requested a review from a team August 30, 2022 22:45
changelog: Internal, Attempts API, Track event idv_phone_otp_sent_rate_limited (LG-7111)
@jc-gsa jc-gsa force-pushed the LG-7111-idv-phone-otp-sent-rate-limited branch from 636bf7d to 3a54056 Compare August 30, 2022 22:46
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -0,0 +1,36 @@
require 'rails_helper'

RSpec.describe Idv::PhoneOtpRateLimitable, type: :controller do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding specs for this previously untested controller!!!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to that!

@@ -0,0 +1,36 @@
require 'rails_helper'

RSpec.describe Idv::PhoneOtpRateLimitable, type: :controller do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to that!

@jc-gsa jc-gsa merged commit 075817e into main Sep 6, 2022
@jc-gsa jc-gsa deleted the LG-7111-idv-phone-otp-sent-rate-limited branch September 6, 2022 22:07
@zachmargolis zachmargolis mentioned this pull request Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants