Skip to content

Increase strictness in parsing timestamp parameter in Attempts API #6874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchellhenke merged 1 commit into from
Aug 30, 2022
Merged

Increase strictness in parsing timestamp parameter in Attempts API #6874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/controllers/api/irs_attempts_api_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def timestamp
timestamp_param = params.permit(:timestamp)[:timestamp]
return nil if timestamp_param.nil?

ActiveSupport::TimeZone['UTC'].parse(timestamp_param)
Time.strptime(timestamp_param, '%Y-%m-%dT%H:%M:%S%z')
rescue ArgumentError
nil
end
Expand Down
3 changes: 3 additions & 0 deletions spec/controllers/api/irs_attempts_api_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,9 @@
it 'returns an error with invalid timestamp parameter' do
post :create, params: { timestamp: 'abc' }
expect(response.status).to eq 422

post :create, params: { timestamp: 'T14' }
expect(response.status).to eq 422
end

it 'authenticates the client' do
Expand Down