Skip to content

Lg-7320 shortened url #6867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peggles2 merged 3 commits into from
Aug 30, 2022
Merged

Lg-7320 shortened url #6867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
40de91f
update GpoConformationExporter to not include https in the domain name
peggles2 Aug 29, 2022
6ef995a
Add changelog
peggles2 Aug 30, 2022
097d8d7
remove https://
peggles2 Aug 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/services/gpo_confirmation_exporter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def make_entry_row(entry)
format_date(now),
format_date(due),
service_provider&.friendly_name || 'Login.gov',
"https://#{IdentityConfig.store.domain_name}",
IdentityConfig.store.domain_name,
]
end

Expand Down
4 changes: 2 additions & 2 deletions spec/services/gpo_confirmation_exporter_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@
it 'creates psv string' do
result = <<~HEREDOC
01|2\r
02|John Johnson|123 Sesame St|""|Anytown|WA|98021|ZYX987|July 6, 2018|July 16, 2018|#{service_provider.friendly_name}|https://#{IdentityConfig.store.domain_name}\r
02|Söme Öne|123 Añy St|Sté 123|Sömewhere|KS|66666-1234|ABC123|July 6, 2018|July 16, 2018|Login.gov|https://#{IdentityConfig.store.domain_name}\r
02|John Johnson|123 Sesame St|""|Anytown|WA|98021|ZYX987|July 6, 2018|July 16, 2018|#{service_provider.friendly_name}|#{IdentityConfig.store.domain_name}\r
02|Söme Öne|123 Añy St|Sté 123|Sömewhere|KS|66666-1234|ABC123|July 6, 2018|July 16, 2018|Login.gov|#{IdentityConfig.store.domain_name}\r
HEREDOC

psv_contents = subject.run
Expand Down