Skip to content

LG-7096 Update Event: IDV doc upload submitted #6850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olatifflexion merged 1 commit into from
Aug 26, 2022
+1 −2
Merged

LG-7096 Update Event: IDV doc upload submitted #6850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/forms/idv/api_image_upload_form.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ def update_analytics(client_response)
last_name: pii_from_doc[:last_name],
date_of_birth: pii_from_doc[:dob],
address: pii_from_doc[:address1],
failure_reason: client_response.errors&.presence,
failure_reason: client_response.errors&.except(:hints)&.presence,
Copy link
Copy Markdown
Contributor

@jc-gsa jc-gsa Aug 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice touch with the .presence call. This should probably always be used.

)
end

Expand Down
1 change: 0 additions & 1 deletion spec/controllers/idv/image_uploads_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -713,7 +713,6 @@
failure_reason: {
general: [I18n.t('doc_auth.errors.alerts.barcode_content_check')],
back: [I18n.t('doc_auth.errors.general.fallback_field_level')],
hints: true,
},
document_state: nil,
document_number: nil,
Expand Down