Remove custom "Required" form validation message#6782
Merged
Conversation
**Why**: - They are inconsistent with desired error feedback UX, which should be implemented as design system error messages via ValidatedFieldComponent. - Improves performance of critical path by reducing JavaScript (and locale data) bundle size. - For context, the Sign In page loads locale data which includes only this one string for required fields. - Contributes toward removal of form-validation pack, to be removed between this and #6771 changelog: Improvements, Form Validation, Use consistent error message feedback for form validation
**Why**: For consistent error feedback
jmhooper
approved these changes
Aug 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
data-form-validation-messagehandling and related context at Form Validation: Limit custom validation reset to own validation #5631)Implementation Notes:
While I did update the Sign In page for consistency, there may be other places in the application which still use native form validation, and in those cases the required field feedback will revert from the customized "This field is required" to the browser default (e.g. "Please fill in this field" in Chrome). I think we should aim to update these fields to the standard error feedback display than to continue propping up this non-standard error message customization.
Screenshots: