Merged
Conversation
changelog: Internal, Attempts API, Captures client port number
n1zyy
commented
Aug 12, 2022
| expect(metadata[:user_ip_address]).to eq '127.0.0.1' | ||
| expect(metadata[:irs_application_url]).to eq 'http://localhost:7654/auth/result' | ||
| expect(metadata[:unique_session_id]).to be_a(String) | ||
| expect(metadata[:success]).to be_truthy |
Contributor
Author
There was a problem hiding this comment.
I'm kind of ad-libbing stuff here. I wanted to test some attributes of the events, but didn't want to go through a ton of work in this file to mock out all the request parameters. Is this an improvement, or is doing some but not all of this worse than nothing?
n1zyy
commented
Aug 15, 2022
n1zyy
commented
Aug 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: Internal, Attempts API, Captures client port number