Fix 500 error when handling unsafe redirects#6735
Merged
mitchellhenke merged 1 commit intomainfrom Aug 15, 2022
Merged
Conversation
jmhooper
approved these changes
Aug 12, 2022
zachmargolis
approved these changes
Aug 12, 2022
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM! bonus points for a spec
Contributor
Author
I can add one for this route, but we do have the ApplicationController behavior covered here |
Contributor
If it's easy, yes! It makes for a good regression case if we ever change/remove that behavior at the base class |
mitchellhenke
force-pushed
the
mitchellhenke/fix-unsafe-redirect-500-part-2
branch
from
55596cd to
df3c623
Compare
changelog: Bug Fixes, Security, Fix 500 error when handling unsafe redirects
mitchellhenke
force-pushed
the
mitchellhenke/fix-unsafe-redirect-500-part-2
branch
from
df3c623 to
eb7cb7b
Compare
mitchellhenke
pushed a commit
that referenced
this pull request
Aug 15, 2022
changelog: Bug Fixes, Security, Fix 500 error when handling unsafe redirects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Relic
Similar strategy as in #6682, and since this controller does not inherit from
ApplicationController, we can make similar changes.