Skip to content

Log whether a requested GPO letter is being resent #6709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmhooper merged 3 commits into from
Aug 9, 2022
Merged

Log whether a requested GPO letter is being resent #6709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa12de4
Log whether a requested GPO letter is being resent
jmhooper Aug 9, 2022
2d57136
changelog: Improvements, Identity Verification, Internal logging for …
jmhooper Aug 9, 2022
d17eeae
delint
jmhooper Aug 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/controllers/idv/gpo_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def gpo_mail_service
private

def update_tracking
analytics.idv_gpo_address_letter_requested(enqueued_at: Time.zone.now)
analytics.idv_gpo_address_letter_requested(enqueued_at: Time.zone.now, resend: true)
create_user_event(:gpo_mail_sent, current_user)

ProofingComponent.create_or_find_by(user: current_user).update(address_check: 'gpo_letter')
Expand Down
2 changes: 1 addition & 1 deletion app/controllers/idv/review_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ def init_profile
idv_session.create_profile_from_applicant_with_password(password)

if idv_session.address_verification_mechanism == 'gpo'
analytics.idv_gpo_address_letter_requested(enqueued_at: Time.zone.now)
analytics.idv_gpo_address_letter_requested(enqueued_at: Time.zone.now, resend: false)
end

if idv_session.profile.active?
Expand Down
5 changes: 3 additions & 2 deletions app/services/analytics_events.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,13 +635,14 @@ def idv_forgot_password_confirmed
track_event('IdV: forgot password confirmed')
end

# GPO address letter requested
# @param [DateTime] enqueued_at
# @param [Boolean] resend
# GPO letter was requested and time was recorded
def idv_gpo_address_letter_requested(enqueued_at: Time.zone.now, **extra)
def idv_gpo_address_letter_requested(enqueued_at:, resend:, **extra)
track_event(
'IdV: USPS address letter requested',
enqueued_at: enqueued_at,
resend: resend,
**extra,
)
end
Expand Down
14 changes: 0 additions & 14 deletions spec/services/analytics_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,18 +227,4 @@
analytics.track_event('Trackable Event')
end
end

describe '#idv_gpo_address_letter_requested' do
let(:analytics) { FakeAnalytics.new }

it 'logs letter requested with enqueued at' do
enqueued_at = Time.zone.now
analytics.idv_gpo_address_letter_requested(enqueued_at: enqueued_at)

expect(analytics).to have_logged_event(
'IdV: USPS address letter requested',
enqueued_at: enqueued_at,
)
end
end
end